feat(spec): add table_properties.rs to spec
#1733
Open
+202
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
requested changes
Oct 11, 2025
There was a problem hiding this comment.
Thanks @kaushiksrini for this pr. Although this is quite interesting, I feel that this design is a little hard to maintain. What I expected is sth like following:
pub struct TableProperties {
#[key="commit.retry.num-retries"]
#[default="4"]
pub commit_num_retries: usize,
...
}
impl TryFrom<&HashMap<String, String>>> for TableProperties {
// parse by entry key or use default value
}Note we don't have a defult method for TableProperties, since some values don't have default methods. See https://github.com/apache/iceberg/blob/b15f4ac1795d25f9db5aa1559b677d57d1bacceb/core/src/main/java/org/apache/iceberg/TableProperties.java#L25 for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
table_properties.rsto hold all properties #1505 .What changes are included in this PR?
table_properties.rsto hold and validate properties and set default values. Uses macros to simplify setting new properties.Are these changes tested?
In the process of adding them.